lkl tools: add symlink support to cptofs#294
Conversation
|
Can one of the admins verify this patch? |
|
Actually, I'm seeing some weirdness with Edit: simple typo in the |
copumpkin
force-pushed
the
cptofs-symlinks
branch
from
3079da2 to
8a0fc49
Compare
|
@lkl-jenkins: test this please |
|
@tavip I couldn't actually find a test for |
tavip
left a comment
tavip
left a comment
There was a problem hiding this comment.
Looks good to me, almost ready to merge. Could you please fix the checkpatch warnings / errors?
|
@copumpkin With regards to tests, if you can add something in tools/lkl/tests (maybe cptofs.sh?), it would be great ! |
|
@tavip can I fix checkpatch issues and then submit a separate PR for tests for |
Signed-off-by: Dan Peebles <pumpkin@me.com>
copumpkin
force-pushed
the
cptofs-symlinks
branch
from
8a0fc49 to
c22fee9
Compare
|
Fixed checkpatch issues! |
Of course, that is the way I would prefer it too. Thanks! |
|
@lkl-jenkins: test this please |
|
(as an aside, is there an LKL IRC channel or other chat community somewhere I can go idle?) |
|
Thanks! |
|
@copumpkin There is a mailing list. Besides that @thehajime and I idle in #lkl at FreeNode, but so far we are the only ones and have not really pursued the idea of creating an "official" channel any further... |
4 participants
This should fix #291. I tried to replicate the style used in cptofs.c but this is my first commit to the project so please let me know if I missed something!
I was tempted to make
stat_srcjust take astruct statpointer rather than adding another pointer parameter, but then I'd have to copy the fields fromlkl_statinto it and this seemed slightly cleaner.This change is